Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Hardware accelerated off-screen rendering #41972

Open
3 tasks done
reitowo opened this issue Apr 26, 2024 · 3 comments · May be fixed by #42001
Open
3 tasks done

[Feature Request]: Hardware accelerated off-screen rendering #41972

reitowo opened this issue Apr 26, 2024 · 3 comments · May be fixed by #42001

Comments

@reitowo
Copy link

reitowo commented Apr 26, 2024

Preflight Checklist

Problem Description

OnPaint has always been sharing the OSR pictures using FrameSinkVideoCapturer, but via CPU. This is not optimal performance, and a GPU based OSR would be in favor instead of the current one.

CEF has OnAcceleratedPaint, but was dead since M103, however this PR reintroduced the capability since M125 (possibly backport to M124): https://bitbucket.org/chromiumembedded/cef/pull-requests/734

I think electron fundamentally use same arch as CEF does, and I think we can also port this to electron.

A PR will follow shortly.

Proposed Solution

https://bitbucket.org/chromiumembedded/cef/pull-requests/734

Alternatives Considered

No

Additional Information

No response

@reitowo reitowo changed the title [Feature Request]: Hardware accelerated off-screen rendering (again) [Feature Request]: Hardware accelerated off-screen rendering Apr 26, 2024
@reitowo
Copy link
Author

reitowo commented Apr 30, 2024

Good news, things are working.

image

@reitowo
Copy link
Author

reitowo commented Apr 30, 2024

PR: #42001

@reitowo reitowo linked a pull request Apr 30, 2024 that will close this issue
5 tasks
@Galkon
Copy link

Galkon commented May 3, 2024

This would be much welcomed in our stack, big thanks for taking this on. Hope to use it in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants