Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Fullscreen permission handling doesn't work for WebContentsView #41941

Closed
3 tasks done
andreasdj opened this issue Apr 23, 2024 · 0 comments · Fixed by #41966
Closed
3 tasks done

[Bug]: Fullscreen permission handling doesn't work for WebContentsView #41941

andreasdj opened this issue Apr 23, 2024 · 0 comments · Fixed by #41966
Assignees
Labels
30-x-y bug 🪲 component/WebContentsView has-repro-gist Issue can be reproduced with code at https://gist.github.com/ platform/all status/confirmed A maintainer reproduced the bug or agreed with the feature

Comments

@andreasdj
Copy link
Contributor

Preflight Checklist

Electron Version

30.0.1

What operating system are you using?

Windows

Operating System Version

Windows 10 Enterprise version 22H2

What arch are you using?

x64

Last Known Working Electron version

No response

Expected Behavior

When adding a permission request handler to a session used by a WebContentsView, then it is possible to allow elements to go into fullscreen mode.

Actual Behavior

The registered permission request handler is called but when the callback method is invoked nothing happens.

Testcase Gist URL

https://gist.github.com/8cebc0fe88155d5310930cfb3bcc25c7

Additional Information

Although the deprecated BrowserView is said to be a shim on top of the WebContentsView, the permission handling is working for the BrowserView. The provided gist contains buttons to request going into fullscreen mode for the main window and for two child views (one using a BrowserView, another using a WebContentsView).

I have only done tests specifically for fullscreen permission requests but it's possible that this is applicable to all types of permission requests.

@electron-issue-triage electron-issue-triage bot added the has-repro-gist Issue can be reproduced with code at https://gist.github.com/ label Apr 23, 2024
@codebytere codebytere added status/confirmed A maintainer reproduced the bug or agreed with the feature component/WebContentsView 30-x-y platform/all labels Apr 25, 2024
@codebytere codebytere self-assigned this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
30-x-y bug 🪲 component/WebContentsView has-repro-gist Issue can be reproduced with code at https://gist.github.com/ platform/all status/confirmed A maintainer reproduced the bug or agreed with the feature
Projects
Status: 🛠️ Fixed for Next Release
Development

Successfully merging a pull request may close this issue.

2 participants