fix: setTitleBarOverlay should be implemented on BaseWindow
#41960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
codebytere
force-pushed
the
set-titlebar-base-window
branch
from
1947103
to
a70bfec
Compare
codebytere
force-pushed
the
set-titlebar-base-window
branch
from
a70bfec
to
fa0e25d
Compare
jkleinsc
approved these changes
Apr 29, 2024
|
Release Notes Persisted
|
|
I was unable to backport this PR to "30-x-y" cleanly; |
trop
bot
removed
the
target/30-x-y
|
I was unable to backport this PR to "29-x-y" cleanly; |
|
I was unable to backport this PR to "31-x-y" cleanly; |
trop
bot
added
needs-manual-bp/29-x-y
needs-manual-bp/31-x-y
and removed
target/29-x-y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #41938.
Moves
setTitleBarOverlayto BaseWindow.Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where
setTitleBarOverlaydidn't work as expected when called onBaseWindow.