chore: cherry-pick 933cc81c6bad from chromium #36222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppontes
added
21-x-y
backport-check-skip
electron-cation
bot
added
new-pr 🌱
ppontes
force-pushed
the
cherry-pick/21-x-y/chromium/933cc81c6bad
branch
from
7d575ec
to
644fbaf
Compare
jkleinsc
approved these changes
Nov 2, 2022
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove symlinks from FileChooserImpl folder upload result
FileChooserImpl is the browser-side implementation of
. When uploading a whole folder, it
currently uses DirectoryLister to list all the files in a
directory. The result also includes resolved symbolic links
(which may even hide deep in some subfolder), which is not a
desired behavior.
Therefore, this patch removes all symbolic links from the
result by checking each file against
base::IsLink(). Sincethe function needs blocking calls to access file data, the
job is sent to a worker pool thread.
Fixed: 1345275
Change-Id: I8ab58214c87944408c64b177e915247a7485925b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3866767
Reviewed-by: Austin Sullivan asully@chromium.org
Commit-Queue: Xiaocheng Hu xiaochengh@chromium.org
Reviewed-by: Mason Freed masonf@chromium.org
Reviewed-by: Alex Moshchuk alexmos@chromium.org
Cr-Commit-Position: refs/heads/main@{#1045491}
Notes: Security: backported fix for CVE-2022-3656.