Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: left is a valid mode in contents.openDevTools() options #32372

Merged
merged 1 commit into from Jan 10, 2022
Merged

docs: left is a valid mode in contents.openDevTools() options #32372

merged 1 commit into from Jan 10, 2022

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jan 6, 2022

Description of Change

Add missing left mode to contents.openDevTools() options.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • relevant documentation is changed or added

Release Notes

Notes: none

@miniak miniak added semver/patch backwards-compatible bug fixes target/13-x-y labels Jan 6, 2022
@miniak miniak self-assigned this Jan 6, 2022
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 6, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 7, 2022
@codebytere
Copy link
Member

Failure not relevant.

@codebytere codebytere merged commit 6d8a858 into main Jan 10, 2022
6 checks passed
@codebytere codebytere deleted the miniak/devtools-mode-left branch January 10, 2022 09:50
@release-clerk
Copy link

release-clerk bot commented Jan 10, 2022

No Release Notes

@trop
Copy link
Contributor

trop bot commented Jan 10, 2022

I was unable to backport this PR to "13-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Jan 10, 2022

I was unable to backport this PR to "14-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/14-x-y label Jan 10, 2022
@trop
Copy link
Contributor

trop bot commented Jan 10, 2022

I was unable to backport this PR to "15-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Jan 10, 2022

I was unable to backport this PR to "16-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot mentioned this pull request Jan 10, 2022
Merged
@trop
Copy link
Contributor

trop bot commented Jan 10, 2022

I have automatically backported this PR to "17-x-y", please check out #32392

miniak added a commit that referenced this pull request Jan 10, 2022
@miniak
docs: left is a valid mode in contents.openDevTools() options (#32372)
ffcaea0
@miniak miniak mentioned this pull request Jan 10, 2022
Merged
@trop
Copy link
Contributor

trop bot commented Jan 10, 2022

@miniak has manually backported this PR to "16-x-y", please check out #32403

miniak added a commit that referenced this pull request Jan 10, 2022
@miniak
docs: left is a valid mode in contents.openDevTools() options (#32372)
212d0b1
@miniak miniak mentioned this pull request Jan 10, 2022
Merged
@trop
Copy link
Contributor

trop bot commented Jan 10, 2022

@miniak has manually backported this PR to "15-x-y", please check out #32404

miniak added a commit that referenced this pull request Jan 10, 2022
@miniak
docs: left is a valid mode in contents.openDevTools() options (#32372)
154a0fb
@miniak miniak mentioned this pull request Jan 10, 2022
Merged
@trop
Copy link
Contributor

trop bot commented Jan 10, 2022

@miniak has manually backported this PR to "14-x-y", please check out #32405

jkleinsc pushed a commit that referenced this pull request Jan 10, 2022
@miniak
docs: left is a valid mode in contents.openDevTools() options (#32372) (
68a512a 
#32403)
jkleinsc pushed a commit that referenced this pull request Jan 10, 2022
@miniak
docs: left is a valid mode in contents.openDevTools() options (#32372) (
250b7ed 
#32404)
jkleinsc pushed a commit that referenced this pull request Jan 10, 2022
@miniak
docs: left is a valid mode in contents.openDevTools() options (#32372) (
d4edab2 
#32405)
t57ser pushed a commit to t57ser/electron that referenced this pull request Jan 25, 2022
@miniak @t57ser
docs: left is a valid mode in contents.openDevTools() options (electr…
aaf3180 
…on#32372)
@commit-lint commit-lint bot mentioned this pull request Mar 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppontes ppontes ppontes approved these changes

Assignees

@miniak miniak

Labels
documentation 📓 semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@miniak @codebytere @ppontes @dsanders11