Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid double call in OnRefreshComplete on aura platforms #32052

Merged
merged 1 commit into from
Nov 30, 2021
Merged

fix: avoid double call in OnRefreshComplete on aura platforms #32052

merged 1 commit into from
Nov 30, 2021

Conversation

MarshallOfSound
Copy link
Member

Fixes https://sentry.io/share/issue/23956e3126894e84a9ab73a87b22c09d/

No repro so no test case but basically there is a scenario on aura platforms where we can end up calling OnRefreshComplete twice as a result of our patch. We should ensure we are only calling it once.

Notes: Fixed potential crash on Windows and Linux when using desktopCapturer.getSources

@MarshallOfSound MarshallOfSound requested a review from a team as a code owner November 29, 2021 22:19
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 29, 2021
@MarshallOfSound MarshallOfSound added target/16-x-y semver/patch backwards-compatible bug fixes labels Nov 29, 2021
VerteDinde
VerteDinde approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 30, 2021
@VerteDinde VerteDinde merged commit ed7f9ad into main Nov 30, 2021
@VerteDinde VerteDinde deleted the fix-media-list-crash branch November 30, 2021 23:12
@release-clerk
Copy link

release-clerk bot commented Nov 30, 2021

Release Notes Persisted

Fixed potential crash on Windows and Linux when using desktopCapturer.getSources

@trop
Copy link
Contributor

trop bot commented Nov 30, 2021

I was unable to backport this PR to "16-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot mentioned this pull request Nov 30, 2021
Merged
@trop
Copy link
Contributor

trop bot commented Nov 30, 2021

I have automatically backported this PR to "17-x-y", please check out #32070

VerteDinde added a commit that referenced this pull request Dec 3, 2021
@VerteDinde
fix: avoid double call in OnRefreshComplete on aura platforms (#32052)
b33a040
@VerteDinde VerteDinde mentioned this pull request Dec 3, 2021
Merged
@trop
Copy link
Contributor

trop bot commented Dec 3, 2021

@VerteDinde has manually backported this PR to "16-x-y", please check out #32089

VerteDinde added a commit that referenced this pull request Dec 3, 2021
@VerteDinde
fix: avoid double call in OnRefreshComplete on aura platforms (#32052) (
ebd3360 
#32089)
t57ser pushed a commit to t57ser/electron that referenced this pull request Jan 25, 2022
@MarshallOfSound @t57ser
fix: avoid double call in OnRefreshComplete on aura platforms (electr…
022457c 
…on#32052)
@commit-lint commit-lint bot mentioned this pull request Mar 3, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MarshallOfSound @VerteDinde