chore: use std::forward() in ConvertToV8()
#31858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
The variable `input` is accepted by a universal reference, so it doesn't make sense to cast a potential lvalue reference into an rvalue reference. In case `input` is an lvalue reference, we should rather forward the value as is to `ToV8()`. Signed-off-by: Darshan Sen <darshan.sen@postman.com>
3 tasks
trop
bot
added
16-x-y
backport
jkleinsc
approved these changes
Nov 16, 2021
jkleinsc
deleted the
trop/16-x-y-bp-chore-use-std-forward-in-converttov8--1637050552937
branch
|
No Release Notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #31817
See that PR for details.
Notes: none