Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change cookie default from NO_RESTRICTION to LAX_MODE #31839

Merged
merged 2 commits into from
Nov 15, 2021
Merged

fix: change cookie default from NO_RESTRICTION to LAX_MODE #31839

merged 2 commits into from
Nov 15, 2021

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Nov 15, 2021

Backport of #31800

See that PR for details.

Notes: Fixed default setting used when setting an insecure cookie on a secure site.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 15, 2021
@trop trop bot requested a review from VerteDinde November 15, 2021 15:20
@trop trop bot mentioned this pull request Nov 15, 2021
Merged
5 tasks
@trop trop bot added 16-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Nov 15, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 15, 2021
VerteDinde
VerteDinde requested changes Nov 15, 2021
View reviewed changes
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change changes the current default behavior of sub-request redirects (top level navigation redirects are fine), checking to see if our behavior matches Chrome before merging

VerteDinde
VerteDinde approved these changes Nov 15, 2021
View reviewed changes
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, this behavior does seem to match Chrome, I think we're good 🙂

@VerteDinde VerteDinde merged commit 55a293c into 16-x-y Nov 15, 2021
@VerteDinde VerteDinde deleted the trop/16-x-y-bp-fix-change-cookie-default-from-no_restriction-to-lax_mode-1636989625069 branch November 15, 2021 18:33
@release-clerk
Copy link

release-clerk bot commented Nov 15, 2021

Release Notes Persisted

Fixed default setting used when setting an insecure cookie on a secure site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
16-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@VerteDinde