Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update test automation doc #31506

Merged
merged 8 commits into from
Oct 28, 2021
Merged

Conversation

erickzhao
Copy link
Member

@erickzhao erickzhao commented Oct 20, 2021

Description of Change

Supersedes #29240, which was failing lint and had some merge conflcits.

Combines the testing docs into a single doc, adds the updated WDIO instructions from #29240, and removes references to Spectron and Devtron.

cc @christian-bromann @molant

Checklist

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 20, 2021
@erickzhao erickzhao changed the title Automated test doc docs: update test automation doc Oct 20, 2021
Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments.

docs/tutorial/automated-testing.md Outdated Show resolved Hide resolved
capabilities: [{
browserName: 'chrome',
'goog:chromeOptions': {
binary: '/path/to/your/electron/binary', // Path to your Electron binary.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we assume that the user is in the project root directory and maybe then say, __dirname + '/dist/electron.exe'?

@erickzhao erickzhao marked this pull request as ready for review October 21, 2021 16:02
Co-authored-by: Christian Bromann <github@christian-bromann.com>
@erickzhao erickzhao requested a review from a team October 21, 2021 16:04
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 21, 2021
@zcbenz zcbenz merged commit ec34c6c into electron:main Oct 28, 2021
@release-clerk
Copy link

release-clerk bot commented Oct 28, 2021

No Release Notes

@trop
Copy link
Contributor

trop bot commented Oct 28, 2021

I was unable to backport this PR to "15-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Oct 28, 2021

I have automatically backported this PR to "16-x-y", please check out #31613

VerteDinde added a commit that referenced this pull request Nov 3, 2021
* Update WebdriverIO documentation

* Update docs/tutorial/using-selenium-and-webdriver.md

Co-authored-by: Jeremy Rose <nornagon@nornagon.net>

* Update docs/tutorial/using-selenium-and-webdriver.md

Co-authored-by: Jeremy Rose <nornagon@nornagon.net>

* docs: update automated testing docs

* lint

* update

* Update docs/tutorial/automated-testing.md

Co-authored-by: Christian Bromann <github@christian-bromann.com>

* fixes

Co-authored-by: Christian Bromann <github@christian-bromann.com>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
@trop
Copy link
Contributor

trop bot commented Nov 3, 2021

@VerteDinde has manually backported this PR to "15-x-y", please check out #31699

VerteDinde added a commit that referenced this pull request Nov 4, 2021
* Update WebdriverIO documentation

* Update docs/tutorial/using-selenium-and-webdriver.md

Co-authored-by: Jeremy Rose <nornagon@nornagon.net>

* Update docs/tutorial/using-selenium-and-webdriver.md

Co-authored-by: Jeremy Rose <nornagon@nornagon.net>

* docs: update automated testing docs

* lint

* update

* Update docs/tutorial/automated-testing.md

Co-authored-by: Christian Bromann <github@christian-bromann.com>

* fixes

Co-authored-by: Christian Bromann <github@christian-bromann.com>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>

Co-authored-by: Christian Bromann <github@christian-bromann.com>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
t57ser pushed a commit to t57ser/electron that referenced this pull request Jan 25, 2022
* Update WebdriverIO documentation

* Update docs/tutorial/using-selenium-and-webdriver.md

Co-authored-by: Jeremy Rose <nornagon@nornagon.net>

* Update docs/tutorial/using-selenium-and-webdriver.md

Co-authored-by: Jeremy Rose <nornagon@nornagon.net>

* docs: update automated testing docs

* lint

* update

* Update docs/tutorial/automated-testing.md

Co-authored-by: Christian Bromann <github@christian-bromann.com>

* fixes

Co-authored-by: Christian Bromann <github@christian-bromann.com>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants