fix: remove CHECK_EQ for swapped RFH #30820
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
fixes #30807
Backport a fix from #29290 which has already made it into
main
and15-x-y
branches.The check below will get thrown sometimes when the
old_host
is a nullptr which I hadn't expected initially. The code works fine with this check removed.electron/shell/browser/api/electron_api_web_contents.cc
Lines 1426 to 1429 in c0da647
Checklist
npm test
passesRelease Notes
Notes: Fixed crash that occasionally happens when closing or opening BrowserWindows.