Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick fix for 1233564 from chromium #30755

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Aug 30, 2021

Backport of #30636

See that PR for details.

Notes: Security: Backported fix for 1233564.

* chore: cherry-pick fix for 1233564 from chromium

Protect HRTF database loader thread from access by different threads

This patch add a new mutex locker around the HRTF database loader
thread to ensure the safe exclusive access of the loader thread
and the HRTF database.

(cherry picked from commit 6811e850ee10847da16c4d5fdc0f845494586b65)

Bug: 1233564
Change-Id: Ie12b99ffe520d3747e34af387a37637a10aab38a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3068260
Auto-Submit: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>

[modify] https://crrev.com/033f0bdcbe538c61f532e97b03cb9c092a94b413/third_party/blink/renderer/platform/audio/hrtf_database_loader.cc
[modify] https://crrev.com/033f0bdcbe538c61f532e97b03cb9c092a94b413/third_party/blink/renderer/platform/audio/hrtf_database_loader.h

* chore: update patches

Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
@trop trop bot requested a review from a team as a code owner August 30, 2021 12:26
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 30, 2021
@trop trop bot requested a review from zcbenz August 30, 2021 12:26
@trop trop bot added 11-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Aug 30, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 30, 2021
@jkleinsc
Copy link
Contributor

Merging as CI failures are addressed in #30096, which was never backported to 11-x-y.

@jkleinsc jkleinsc merged commit 7576621 into 11-x-y Aug 30, 2021
@jkleinsc jkleinsc deleted the trop/11-x-y-bp-chore-cherry-pick-fix-for-1233564-from-chromium-1630326402669 branch August 30, 2021 20:50
@release-clerk
Copy link

release-clerk bot commented Aug 30, 2021

Release Notes Persisted

Security: Backported fix for 1233564.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants