Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Revert back to webview fullscreen mechanics prior to 13.1.7 #30750

Open
3 tasks done
ryankashi opened this issue Aug 30, 2021 · 2 comments
Open
3 tasks done

Comments

@ryankashi
Copy link

ryankashi commented Aug 30, 2021

Preflight Checklist

Problem Description

PR #29987 changed the functionality of how Webviews operate with fullscreen requests. Prior to this PR, Webviews when fullscreened would only take up the existing space inside of their html element which (for exampe the application that I am working on) is how the Webview should operate.

Now, however, Webviews that are fullscreened will take up the entire space of the monitor regardless of the size of the webview element that they are embedding inside of, with no way of returning to the original views created prior to PR #29987

Proposed Solution

We should be able to set the Fullscreen functionality of the webview object in order to allow for the same fullscreen behavior prior to #29987.

Something such as webview.allowFullScreenOutsideOfElement(true) or webview.allowFullScreenOutsideOfElement(false) in order to ensure that the webview enters its own fullscreen mode while staying within the bounds of the webview html element.

Alternatives Considered

Staying on Electron version 13.1.6. However, this is not ideal as I am missing out on future updates, security fixes, etc

Additional Information

No response

@codebytere
Copy link
Member

cc @miniak @zcbenz - what are your thoughts?

@zcbenz
Copy link
Member

zcbenz commented Sep 1, 2021

Adding an API to revert back to the old fullscreen behavior sounds reasonable to me.

@codebytere codebytere self-assigned this Sep 2, 2021
@codebytere codebytere removed their assignment Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants