New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix code example in process-model.md #30690
Conversation
the demo have two error: - at macos, close all window, the app will not quite, unless press cmd + q - attach preload.js, use preload prop that is member of `webPreferences` property of `BrowserWindow` controller argument
💖 Thanks for opening this pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this! My apologies for the mistakes. 😓
Could you do two things to make the lint checks pass:
- Add
notes: none
to the bottom of your PR description - Modify the PR title to have a
docs:
prefix
Co-authored-by: Erick Zhao <erick@hotmail.ca>
Congrats on merging your first pull request! 🎉🎉🎉 |
No Release Notes |
* Update process-model.md the demo have two error: - at macos, close all window, the app will not quite, unless press cmd + q - attach preload.js, use preload prop that is member of `webPreferences` property of `BrowserWindow` controller argument * Update docs/tutorial/process-model.md Co-authored-by: Erick Zhao <erick@hotmail.ca> Co-authored-by: Cheng Zhao <github@zcbenz.com> Co-authored-by: Erick Zhao <erick@hotmail.ca>
* Update process-model.md the demo have two error: - at macos, close all window, the app will not quite, unless press cmd + q - attach preload.js, use preload prop that is member of `webPreferences` property of `BrowserWindow` controller argument * Update docs/tutorial/process-model.md Co-authored-by: Erick Zhao <erick@hotmail.ca> Co-authored-by: Cheng Zhao <github@zcbenz.com> Co-authored-by: Erick Zhao <erick@hotmail.ca>
* Update process-model.md the demo have two error: - at macos, close all window, the app will not quite, unless press cmd + q - attach preload.js, use preload prop that is member of `webPreferences` property of `BrowserWindow` controller argument * Update docs/tutorial/process-model.md Co-authored-by: Erick Zhao <erick@hotmail.ca> Co-authored-by: Cheng Zhao <github@zcbenz.com> Co-authored-by: Erick Zhao <erick@hotmail.ca>
@erickzhao has manually backported this PR to "14-x-y", please check out #30800 |
* Update process-model.md the demo have two error: - at macos, close all window, the app will not quite, unless press cmd + q - attach preload.js, use preload prop that is member of `webPreferences` property of `BrowserWindow` controller argument * Update docs/tutorial/process-model.md Co-authored-by: Erick Zhao <erick@hotmail.ca> Co-authored-by: Cheng Zhao <github@zcbenz.com> Co-authored-by: Erick Zhao <erick@hotmail.ca>
@erickzhao has manually backported this PR to "15-x-y", please check out #30802 |
* Update process-model.md the demo have two error: - at macos, close all window, the app will not quite, unless press cmd + q - attach preload.js, use preload prop that is member of `webPreferences` property of `BrowserWindow` controller argument * Update docs/tutorial/process-model.md Co-authored-by: Erick Zhao <erick@hotmail.ca> Co-authored-by: Cheng Zhao <github@zcbenz.com> Co-authored-by: Erick Zhao <erick@hotmail.ca> Co-authored-by: Cheng Zhao <github@zcbenz.com>
* Update process-model.md the demo have two error: - at macos, close all window, the app will not quite, unless press cmd + q - attach preload.js, use preload prop that is member of `webPreferences` property of `BrowserWindow` controller argument * Update docs/tutorial/process-model.md Co-authored-by: Erick Zhao <erick@hotmail.ca> Co-authored-by: Cheng Zhao <github@zcbenz.com> Co-authored-by: Erick Zhao <erick@hotmail.ca> Co-authored-by: Cheng Zhao <github@zcbenz.com>
the demo have two error:
cmd
+q
webPreferences
property ofBrowserWindow
controller argumentNotes: none