Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick fix for 1234764 from v8 #30659

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Aug 23, 2021

Backport of #30587

See that PR for details.

Notes: Security: Backported fix for 1234764.

* chore: cherry-pick fix for 1234764 from v8

* chore: update patches

Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
@trop trop bot requested a review from a team as a code owner August 23, 2021 08:07
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 23, 2021
@trop trop bot requested a review from zcbenz August 23, 2021 08:07
@trop trop bot added 11-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Aug 23, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 23, 2021
@deepak1556
Copy link
Member

Rerunning the node tests as they failed on both x64 and ia32

@zcbenz
Copy link
Member

zcbenz commented Aug 30, 2021

The same node tests also fail on other commits in 11-x-y. This happened before though, Circle CI did changes to linux image and some node tests started to fail.

@zcbenz zcbenz merged commit de5a1d1 into 11-x-y Aug 30, 2021
@zcbenz zcbenz deleted the trop/11-x-y-bp-chore-cherry-pick-fix-for-1234764-from-v8-1629706028878 branch August 30, 2021 11:02
@release-clerk
Copy link

release-clerk bot commented Aug 30, 2021

Release Notes Persisted

Security: Backported fix for 1234764.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants