chore: cherry-pick fix for 1233564 from chromium #30636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Protect HRTF database loader thread from access by different threads This patch add a new mutex locker around the HRTF database loader thread to ensure the safe exclusive access of the loader thread and the HRTF database. (cherry picked from commit 6811e850ee10847da16c4d5fdc0f845494586b65) Bug: 1233564 Change-Id: Ie12b99ffe520d3747e34af387a37637a10aab38a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3068260 Auto-Submit: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> [modify] https://crrev.com/033f0bdcbe538c61f532e97b03cb9c092a94b413/third_party/blink/renderer/platform/audio/hrtf_database_loader.cc [modify] https://crrev.com/033f0bdcbe538c61f532e97b03cb9c092a94b413/third_party/blink/renderer/platform/audio/hrtf_database_loader.h
zcbenz
added
semver/patch
This was referenced Aug 25, 2021
deepak1556
approved these changes
Aug 30, 2021
|
Release Notes Persisted
|
This was referenced Aug 30, 2021
trop bot
pushed a commit
that referenced
this pull request
Aug 30, 2021
* chore: cherry-pick fix for 1233564 from chromium Protect HRTF database loader thread from access by different threads This patch add a new mutex locker around the HRTF database loader thread to ensure the safe exclusive access of the loader thread and the HRTF database. (cherry picked from commit 6811e850ee10847da16c4d5fdc0f845494586b65) Bug: 1233564 Change-Id: Ie12b99ffe520d3747e34af387a37637a10aab38a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3068260 Auto-Submit: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> [modify] https://crrev.com/033f0bdcbe538c61f532e97b03cb9c092a94b413/third_party/blink/renderer/platform/audio/hrtf_database_loader.cc [modify] https://crrev.com/033f0bdcbe538c61f532e97b03cb9c092a94b413/third_party/blink/renderer/platform/audio/hrtf_database_loader.h * chore: update patches Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
trop bot
pushed a commit
that referenced
this pull request
Aug 30, 2021
* chore: cherry-pick fix for 1233564 from chromium Protect HRTF database loader thread from access by different threads This patch add a new mutex locker around the HRTF database loader thread to ensure the safe exclusive access of the loader thread and the HRTF database. (cherry picked from commit 6811e850ee10847da16c4d5fdc0f845494586b65) Bug: 1233564 Change-Id: Ie12b99ffe520d3747e34af387a37637a10aab38a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3068260 Auto-Submit: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> [modify] https://crrev.com/033f0bdcbe538c61f532e97b03cb9c092a94b413/third_party/blink/renderer/platform/audio/hrtf_database_loader.cc [modify] https://crrev.com/033f0bdcbe538c61f532e97b03cb9c092a94b413/third_party/blink/renderer/platform/audio/hrtf_database_loader.h * chore: update patches Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
|
I have automatically backported this PR to "12-x-y", please check out #30754 |
|
I have automatically backported this PR to "11-x-y", please check out #30755 |
jkleinsc
pushed a commit
that referenced
this pull request
Aug 30, 2021
* chore: cherry-pick fix for 1233564 from chromium (#30636) * chore: cherry-pick fix for 1233564 from chromium Protect HRTF database loader thread from access by different threads This patch add a new mutex locker around the HRTF database loader thread to ensure the safe exclusive access of the loader thread and the HRTF database. (cherry picked from commit 6811e850ee10847da16c4d5fdc0f845494586b65) Bug: 1233564 Change-Id: Ie12b99ffe520d3747e34af387a37637a10aab38a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3068260 Auto-Submit: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> [modify] https://crrev.com/033f0bdcbe538c61f532e97b03cb9c092a94b413/third_party/blink/renderer/platform/audio/hrtf_database_loader.cc [modify] https://crrev.com/033f0bdcbe538c61f532e97b03cb9c092a94b413/third_party/blink/renderer/platform/audio/hrtf_database_loader.h * chore: update patches Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> * Update .patches Co-authored-by: Cheng Zhao <zcbenz@gmail.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
zcbenz
added a commit
that referenced
this pull request
Sep 21, 2021
* chore: cherry-pick fix for 1233564 from chromium (#30636) * chore: cherry-pick fix for 1233564 from chromium Protect HRTF database loader thread from access by different threads This patch add a new mutex locker around the HRTF database loader thread to ensure the safe exclusive access of the loader thread and the HRTF database. (cherry picked from commit 6811e850ee10847da16c4d5fdc0f845494586b65) Bug: 1233564 Change-Id: Ie12b99ffe520d3747e34af387a37637a10aab38a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3068260 Auto-Submit: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> [modify] https://crrev.com/033f0bdcbe538c61f532e97b03cb9c092a94b413/third_party/blink/renderer/platform/audio/hrtf_database_loader.cc [modify] https://crrev.com/033f0bdcbe538c61f532e97b03cb9c092a94b413/third_party/blink/renderer/platform/audio/hrtf_database_loader.h * chore: update patches Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> * Update .patches Co-authored-by: Cheng Zhao <zcbenz@gmail.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protect HRTF database loader thread from access by different threads
This patch add a new mutex locker around the HRTF database loader
thread to ensure the safe exclusive access of the loader thread
and the HRTF database.
(cherry picked from commit 6811e850ee10847da16c4d5fdc0f845494586b65)
Bug: 1233564
Change-Id: Ie12b99ffe520d3747e34af387a37637a10aab38a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3068260
Auto-Submit: Hongchan Choi hongchan@chromium.org
Commit-Queue: Kentaro Hara haraken@chromium.org
Reviewed-by: Kentaro Hara haraken@chromium.org
[modify] https://crrev.com/033f0bdcbe538c61f532e97b03cb9c092a94b413/third_party/blink/renderer/platform/audio/hrtf_database_loader.cc
[modify] https://crrev.com/033f0bdcbe538c61f532e97b03cb9c092a94b413/third_party/blink/renderer/platform/audio/hrtf_database_loader.h
Notes: Security: Backported fix for 1233564.