Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Webview not emitting leave-html-full-screen when using ESC key to exit webview fullscreen #30509

Closed
3 tasks done
ryankashi opened this issue Aug 12, 2021 · 0 comments · Fixed by #30537
Closed
3 tasks done

Comments

@ryankashi
Copy link

Preflight Checklist

Electron Version

13.1.9

What operating system are you using?

Windows

Operating System Version

Windows 10

What arch are you using?

x64

Last Known Working Electron version

n/a

Expected Behavior

the leave-html-full-screen event is emitted upon exiting the webview's fullscreen when pressing the ESC key. Clicking out of fullscreen eimts properly.

Actual Behavior

The leave-html-full-screen event is not emitted upon exiting the webview's fullscreen when pressing the ESC key. Clicking out of fullscreen emits properly.

Testcase Gist URL

No response

Additional Information

In addition, I am not sure about other electron users, however I was personally utilizing the webview fullscreen behavior characterized in 3.1.6, and subsequently "fixed" in 3.1.7 and 3.1.8 per the following PRs

#30128

#29987

Upon clicking a fullscreen Webview button, I would like my app to enter fullscreen, while the webview would enter fullscreen in its containing element, as seen prior to the integration of these PRs. Is there a clean way of entering this view instead while staying up to date with the electron version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants