Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 4ce2abc17078 from chromium #30449

Merged
merged 3 commits into from
Aug 13, 2021

Conversation

StevenEBarbaro
Copy link
Contributor

@StevenEBarbaro StevenEBarbaro commented Aug 8, 2021

Forbid script execution for entire lifecycle update

We should not execute script during the lifecycle update except in cases where we we know it is safe to do so, either because we will rerun the lifecycle steps if anything is invalidated (resize observers, intersection observers) or because the script does not have access to invalidate the DOM (e.g. paint worklets).

(cherry picked from commit a73237da91de8aa49aaa5d9479bae51cf387f090)

Bug: 1196853
Change-Id: Id1fdbbb25107cfdc6c234123f845406c28d32914
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2815619
Reviewed-by: Stefan Zager szager@chromium.org
Commit-Queue: Robert Flack flackr@chromium.org
Cr-Original-Commit-Position: refs/heads/master@{#901110}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3058973
Auto-Submit: Robert Flack flackr@chromium.org
Commit-Queue: Stefan Zager szager@chromium.org
Cr-Commit-Position: refs/branch-heads/4472@{#1588}
Cr-Branched-From: 3d60439cfb36485e76a1c5bb7f513d3721b20da1-refs/heads/master@{#870763}

Notes: Security: Backported fix for 1196853.

@StevenEBarbaro StevenEBarbaro requested a review from a team as a code owner August 8, 2021 21:37
@StevenEBarbaro StevenEBarbaro added 13-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes labels Aug 8, 2021
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Aug 8, 2021
patchup bot and others added 2 commits August 8, 2021 21:49

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@zcbenz zcbenz merged commit bb83758 into 13-x-y Aug 13, 2021
@zcbenz zcbenz deleted the cherry-pick/13-x-y/chromium/4ce2abc17078 branch August 13, 2021 00:42
@release-clerk
Copy link

release-clerk bot commented Aug 13, 2021

Release Notes Persisted

Security: Backported fix for 1196853.

@zcbenz
Copy link
Contributor

zcbenz commented Aug 18, 2021

/trop run backport

@trop
Copy link
Contributor

trop bot commented Aug 18, 2021

The backport process for this PR has been manually initiated - here we go! :D

trop bot pushed a commit that referenced this pull request Aug 18, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* chore: cherry-pick 4ce2abc17078 from chromium

* chore: update patches

Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Electron Bot <electron@github.com>
trop bot pushed a commit that referenced this pull request Aug 18, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* chore: cherry-pick 4ce2abc17078 from chromium

* chore: update patches

Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Electron Bot <electron@github.com>
@trop
Copy link
Contributor

trop bot commented Aug 18, 2021

I have automatically backported this PR to "12-x-y", please check out #30581

@trop
Copy link
Contributor

trop bot commented Aug 18, 2021

I have automatically backported this PR to "11-x-y", please check out #30582

zcbenz added a commit that referenced this pull request Aug 19, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* chore: cherry-pick 4ce2abc17078 from chromium (#30449)

* chore: cherry-pick 4ce2abc17078 from chromium

* chore: update patches

Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Electron Bot <electron@github.com>

* Update .patches

* chore: update patches

Co-authored-by: Steven Barbaro <StevenEBarbaro@gmail.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Electron Bot <electron@github.com>
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
13-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants