[Bug]: Button labels in File choosers are untranslated on Linux in e14

[Kilian]

Preflight Checklist

• I have read the Contributing Guidelines for this project.
• I agree to follow the Code of Conduct that this project adheres to.
• I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Electron Version

14.0.0

What operating system are you using?

Ubuntu

Operating System Version

Ubuntu 18.04

What arch are you using?

x64

Last Known Working Electron version

13.1.7

Expected Behavior

The buttons in a (native) file dialog read "Cancel" and "OK"

Actual Behavior

The buttons in a native file dialog read gtk-cancel and gtk-ok.

Testcase Gist URL

https://gist.github.com/Kilian/3de5f404d90d9b12ccaec817fdc4d6da

Additional Information

Main window has a file input, click it to open the File chooser. Test on Ubuntu between 14.x and 13.x to see the difference. Probably caused by #19159

Electron 13.1.7:

Electron 14.0.0-beta.16

[tristan957]

Could you tell me how to run the repro gist and I can take a look?

[tristan957]

One thing to test in your environment is running the example with GTK_USE_PORTAL=1 and not setting the variable at all and seeing if that makes a difference for you.

[tristan957]

gtk-cancel = https://docs.gtk.org/gtk3/const.STOCK_CANCEL.html
gtk-open = https://docs.gtk.org/gtk3/const.STOCK_OPEN.html

[Kilian]

Could you tell me how to run the repro gist and I can take a look?

@tristan957 You can open it in fiddle!

[tristan957]

It seems like a mistake to have shipped with this bug. I have no clue how Electron internationalization works. If someone could inform me how to get a translated string out of the electron infrastructure, I could possibly fix this. Until then, #19159 should be reverted.

[tristan957]

From #gtk with regard to using GTK_STOCK_*...

Well. Step one is just stop. Step two is they need to do translations. No way around it

[codebytere]

@tristan957 working on a fix for this which should be up within a few days.

[tristan957]

@codebytere would appreciate a ping when you have a PR up just so I can learn for myself what the proper fix is.

[codebytere]

@tristan957 just opened it at #30888