Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: 100% crash when you trying to visit about:blank when you set app.allowRendererProcessReuse = false; #30051

Closed
3 tasks done
maple-leaf opened this issue Jul 8, 2021 · 5 comments
Labels
13-x-y bug 🪲 status/confirmed A maintainer reproduced the bug or agreed with the feature

Comments

@maple-leaf
Copy link

Preflight Checklist

Electron Version

13.1.5

What operating system are you using?

Windows

Operating System Version

Window 10 Pro 19042.1052

What arch are you using?

x64

Last Known Working Electron version

No response

Expected Behavior

app not crash

Actual Behavior

app crash

Testcase Gist URL

https://github.com/maple-leaf/electron-crash-on-load-about-blank

Additional Information

  1. clone the reproduce repo
  2. yarn
  3. yarn start
  4. toggle devtools
  5. input location.href="about:blank" in devtools console
  6. app crash
@NhaLeader

This comment has been minimized.

@nornagon
Copy link
Member

nornagon commented Jul 8, 2021

Looks like this is broken at least as far back as 9.x, but is fixed in v14.0.0-nightly.20210426+. v14.0.0-nightly.20210413...v14.0.0-nightly.20210426 is the range I bisected to. That range includes #26874, which removes the allowRendererProcessReuse option, so it's unsurprising that this no longer crashes.

Fiddle version of the repro for convenience: https://gist.github.com/69ced6fc93a72bbdd67e109af36786a1

Not sure if there's anything to fix here. cc @MarshallOfSound

@nornagon nornagon added 13-x-y status/confirmed A maintainer reproduced the bug or agreed with the feature labels Jul 8, 2021
@NhaLeader

This comment has been minimized.

@NhaLeader

This comment has been minimized.

@codebytere
Copy link
Member

Closing as wontfix owing to the removal of allowRendererProcessReuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
13-x-y bug 🪲 status/confirmed A maintainer reproduced the bug or agreed with the feature
Projects
None yet
Development

No branches or pull requests

4 participants