Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: App hijacks focus from win.previewFile since v12.0.9 #29758

Closed
3 tasks done
EtienneLem opened this issue Jun 17, 2021 · 1 comment · Fixed by #29857
Closed
3 tasks done

[Bug]: App hijacks focus from win.previewFile since v12.0.9 #29758

EtienneLem opened this issue Jun 17, 2021 · 1 comment · Fixed by #29857
Assignees
Projects

Comments

@EtienneLem
Copy link

Preflight Checklist

Electron Version

12.0.9

What operating system are you using?

macOS

Operating System Version

macOS Big Sur 11.4

What arch are you using?

arm64 (including Apple Silicon)

Last Known Working Electron version

12.0.8

Expected Behavior

When using win.previewFile, it is expected that pressing spacebar or escape would dismiss the preview window.

Actual Behavior

Nothing happens, or rather your app is still receiving the shortcuts and the preview window is not.

Testcase Gist URL

No response

Additional Information

Given the very small v12.0.9 update, it would be safe to assume that #29235 is responsible for this regression.

Not sure if relevant, but:

Before
When calling win.previewFile it used to trigger a blur followed by an immediate focus event on window:

CleanShot 2021-06-17 at 14 09 45@2x

Now
When calling win.previewFile it triggers this pair of events 4 times in a row:

CleanShot 2021-06-17 at 14 08 50@2x

@nornagon
Copy link
Member

#29235 looks like a possible culprit. cc @deepak1556

@deepak1556 deepak1556 self-assigned this Jun 22, 2021
@ckerr ckerr added this to Unsorted Issues in 14-x-y Jun 23, 2021
@MarshallOfSound MarshallOfSound moved this from Unsorted Issues to Prioritized Regressions in 14-x-y Jun 23, 2021
@sofianguy sofianguy moved this from Prioritized Regressions to Fixed for Next Release in 14-x-y Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
14-x-y
Fixed for Next Release
Development

Successfully merging a pull request may close this issue.

3 participants