Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][macOS]: browser window drag for non-zero x,y browser view bounds #28405

Closed
3 tasks done
b3ll00z opened this issue Mar 26, 2021 · 2 comments · Fixed by #28984
Closed
3 tasks done

[Bug][macOS]: browser window drag for non-zero x,y browser view bounds #28405

b3ll00z opened this issue Mar 26, 2021 · 2 comments · Fixed by #28984
Assignees
Labels
11-x-y 12-x-y 13-x-y bug 🪲 bug/regression ↩️ A new version of Electron broke something has-repro-gist Issue can be reproduced with code at https://gist.github.com/
Projects

Comments

@b3ll00z
Copy link

b3ll00z commented Mar 26, 2021

Preflight Checklist

Electron Version

12.0.2

What operating system are you using?

macOS

Operating System Version

macOS Big Sur 11.2.1

What arch are you using?

x64

Last Known Working Electron version

11.3.0

Expected Behavior

Despite the x, y bounds provided for a browser view, the whole browser window should not be draggable by clicking inside its browser view itself

Actual Behavior

For browser views with both x, y bounds coordinates, such that x > 0 or y > 0, if I click inside the browser view the entire browser window starts dragging

Testcase Gist URL

https://github.com/b3ll00z/electron-quick-start-typescript

To Reproduce

$ git clone https://github.com/b3ll00z/electron-quick-start-typescript
$ cd electron-quick-start-typescript
$ npm install ; npm start
Registrazione.schermo.2021-03-26.alle.08.38.44.mov
@praneetrohida
Copy link

Having the same issue after upgrading to 11.4.x
The browserviews worked fine on 11.3.0

@MarshallOfSound MarshallOfSound added this to Unsorted Issues in 13-x-y Mar 26, 2021
@VerteDinde VerteDinde moved this from Unsorted Issues to Does Not Block Stable in 13-x-y Apr 7, 2021
@Kilian
Copy link
Member

Kilian commented Apr 13, 2021

Here's a test fiddle: https://gist.github.com/b9c5a45bf59f6ba748041d000414e571 This shows devtools inside a browserView.

On launch, the devtools are offset to the right. You can click + drag the window when clicking into the devtools. Additionally, it can not receive keyboard input. When you switch the position of the browserView to {x: 0, y: 0} this does not happen: the window is not dragged and it can receive text input. This behavior shows in any version after 11.3.0. (11.3.0 does not have this issue)

This seems very related to #28268, but it should be noted that fix (which is in 12.0.2) does not fix this issue. Additionally, changing either the x or the y value triggers this dragging behavior.

Other related issues seem #28057, #28228 and #27143.

Looking at the comparison: v11.3.0...v11.4.0 this jumps out as related: 2bcf583

@Kilian Kilian added has-repro-gist Issue can be reproduced with code at https://gist.github.com/ 11-x-y bug/regression ↩️ A new version of Electron broke something labels Apr 13, 2021
@codebytere codebytere self-assigned this Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11-x-y 12-x-y 13-x-y bug 🪲 bug/regression ↩️ A new version of Electron broke something has-repro-gist Issue can be reproduced with code at https://gist.github.com/
Projects
No open projects
13-x-y
Does Not Block Stable
Development

Successfully merging a pull request may close this issue.

5 participants