Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Won't fire keydown event when an input session starting with Sogou IME #28044

Closed
3 tasks done
wyattzheng opened this issue Mar 8, 2021 · 15 comments
Closed
3 tasks done
Labels

Comments

@wyattzheng
Copy link

wyattzheng commented Mar 8, 2021

Preflight Checklist

  • I have read the Contributing Guidelines for this project.
  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version:
    • 11.0.0-beta1
  • Operating System:
    • Windows 10 (18363.1379)
  • Last Known Working Electron version:
    • 10.4.0

Expected Behavior

Some events like input,keydown,keyup,compositionstart,compositionupdate,compositionend would be fired correctly.

Actual Behavior

Some input IMEs like Sogou Pinyin would never trigger the event like keydown when they are inputing.

To Reproduce

for windows:

  1. download the Sogou IME installer from https://pinyin.sogou.com/
  2. try to input Chinese words or Japanese words in integrated terminal of vscode

Screenshots

Additional Information

@wyattzheng wyattzheng changed the title Won't fire compositionstart event when a input session starting with Sogou IME Won't fire compositionstart event when an input session starting with Sogou IME Mar 8, 2021
@wyattzheng wyattzheng changed the title Won't fire compositionstart event when an input session starting with Sogou IME Won't fire keydown event when an input session starting with Sogou IME Mar 8, 2021
@ckerr ckerr added 11-x-y bug/regression ↩️ A new version of Electron broke something platform/windows labels Mar 8, 2021
@ckerr
Copy link
Member

ckerr commented Mar 8, 2021

try to input Chinese words or Japanese words in integrated terminal of vscode

Thanks for reporting this and helping to make Electron better!

Because of time constraints, triaging code with third-party dependencies is usually not feasible for a small team like Electron's.

Would it be possible for you to make a standalone testcase with only the code necessary to reproduce the issue? For example, Electron Fiddle is a great tool for making small test cases and makes it easy to publish your test case to a gist that Electron maintainers can use.

Stand-alone test cases make fixing issues go more smoothly: it ensure everyone's looking at the same issue, it removes all unnecessary variables from the equation, and it can also provide the basis for automated regression tests.

I'm adding the blocked/needs-repro label for this reason. After you make a test case, please link to it in a folloup comment.

Thanks in advance! Your help is appreciated.

@ckerr ckerr added the blocked/need-repro Needs a test case to reproduce the bug label Mar 8, 2021
@wyattzheng
Copy link
Author

@ckerr Sure, i will make a testcase.

@wyattzheng
Copy link
Author

@ckerr i created a gist by Electron Fiddle to reproduce: https://gist.github.com/4e49015759016591d9be00305f734303

@wyattzheng
Copy link
Author

wyattzheng commented Mar 8, 2021

i am also trying to see what causes this between 11.0.0-beta1 and 10.4.0 .
So i am setting up a developing environment . And try to use git bisect to find out the bad commit.

@nornagon
Copy link
Member

@ZhyMC You might be able to narrow it down with Electron Fiddle's built-in bisect feature. Enable it with View > Toggle Bisect Helper.

@wyattzheng
Copy link
Author

wyattzheng commented Mar 12, 2021

@nornagon sure, but these two versions are close.

@wyattzheng
Copy link
Author

wyattzheng commented Mar 12, 2021

it's hard to setting up an electron developing environment. i need to download source of chromium.

@nornagon
Copy link
Member

@ZhyMC you might find https://github.com/electron/build-tools helpful. But also a Fiddle bisect range will probably get us pretty close. You can enable nightlies in Fiddle to get a finer range than released versions.

@ostli
Copy link

ostli commented May 12, 2021

Is there any progress so far?

@asd281533890
Copy link

Same problem with electron 15.2.0. Won't fire any inputEvent with Sougou IME. No problem in chrome browser.

@codebytere
Copy link
Member

Duplicate of #33386

@codebytere codebytere marked this as a duplicate of #33386 Jul 20, 2022
@codebytere codebytere closed this as not planned Won't fix, can't repro, duplicate, stale Jul 20, 2022
@guoyianlin
Copy link

Same problem with electron 16.0.8. Won't fire any inputEvent with Sougou IME. Is there any good solution?

@asd281533890
Copy link

No problem on Windows 7 with electron 11.5.0.

@1339240789
Copy link

bump

@github-actions github-actions bot removed the blocked/need-repro Needs a test case to reproduce the bug label Aug 28, 2023
@1339240789
Copy link

bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants