Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron is breaking locale environment variables on Linux. #26464

Closed
3 tasks done
paeolo opened this issue Nov 12, 2020 · 2 comments
Closed
3 tasks done

Electron is breaking locale environment variables on Linux. #26464

paeolo opened this issue Nov 12, 2020 · 2 comments

Comments

@paeolo
Copy link

paeolo commented Nov 12, 2020

Preflight Checklist

  • I have read the Contributing Guidelines for this project.
  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version:
    • 9.3.4
  • Operating System:
    • ArchLinux 5.9.8-arch1-1
  • Last Known Working Electron version:
    • 9.3.3

Expected Behavior

Running the command locale on a vscode terminal should match locale on a terminal. For instance, using the locale fr_FR.UTF-8 the command should output something like:

[someone@somewhere ~]$ locale
LANG=fr_FR.UTF-8
LC_CTYPE="fr_FR.UTF-8"
LC_NUMERIC="fr_FR.UTF-8"
LC_TIME="fr_FR.UTF-8"
LC_COLLATE="fr_FR.UTF-8"
LC_MONETARY="fr_FR.UTF-8"
LC_MESSAGES="fr_FR.UTF-8"
LC_PAPER="fr_FR.UTF-8"
LC_NAME="fr_FR.UTF-8"
LC_ADDRESS="fr_FR.UTF-8"
LC_TELEPHONE="fr_FR.UTF-8"
LC_MEASUREMENT="fr_FR.UTF-8"
LC_IDENTIFICATION="fr_FR.UTF-8"
LC_ALL=

Actual Behavior

The vscode terminal issue a warning repeatedly and the locale output is not correct.

bash: warning: setlocale: LC_ALL: cannot change locale (fr)
[someone@somewhere ~]$ locale
LANG=fr_FR.UTF-8
LC_CTYPE="C"
LC_NUMERIC="C"
LC_TIME="C"
LC_COLLATE="C"
LC_MONETARY="C"
LC_MESSAGES="C"
LC_PAPER="C"
LC_NAME="C"
LC_ADDRESS="C"
LC_TELEPHONE="C"
LC_MEASUREMENT="C"
LC_IDENTIFICATION="C"
LC_ALL=C

To Reproduce

  • Go on your favorite Linux distribution
  • Install vscode and electron 9.3.4
  • Open a terminal in vscode, you will see the warning
  • Type locale, you will see wrong output

Additional Information

  • If I downgrade electron9 (9.3.4 -> 9.3.3) without touching vscode, the issue is gone.
@Thalley
Copy link

Thalley commented Nov 12, 2020

I suppose this is the same issue as #26443.

@paeolo paeolo closed this as completed Nov 12, 2020
@paeolo
Copy link
Author

paeolo commented Nov 12, 2020

I'm closing to avoid duplicates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants