Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close window when leave fs crash #25604

Merged
merged 1 commit into from Sep 23, 2020
Merged

fix: close window when leave fs crash #25604

merged 1 commit into from Sep 23, 2020

Conversation

codebytere
Copy link
Member

Backport of #25468

See that PR for details.

Notes: Fixed a crash when closing window in an event listener after exiting fullscreen on macOS.

@codebytere codebytere requested a review from a team September 23, 2020 20:03
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 23, 2020
@trop trop bot mentioned this pull request Sep 23, 2020
Merged
5 tasks
@trop trop bot added 10-x-y backport This is a backport PR labels Sep 23, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 23, 2020
@codebytere codebytere merged commit 894d41e into 10-x-y Sep 23, 2020
@release-clerk
Copy link

release-clerk bot commented Sep 23, 2020

Release Notes Persisted

Fixed a crash when closing window in an event listener after exiting fullscreen on macOS.

@codebytere codebytere deleted the fs-crash-leave-10 branch September 23, 2020 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
10-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @jkleinsc