Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick c4f3b713800f from swiftshader #25266

Merged
merged 1 commit into from Sep 2, 2020

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Sep 1, 2020

Fix copying cubemap textures out of bounds

Cubemap textures are created with a border, which means that their
size is larger. Their range is also different. Instead of [0, dim-1],
they have a [-1, dim] range. This means that if we copy them starting
at [0, 0] for their full size, we'll overflow at the end, since the
buffer starts at [-1, -1]. This cl prevents going through the fast
copy path when we have a border.

Bug: chromium:1115345
Change-Id: I333acfd6094645231eb111634359d82ed3d5c787
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/47668
Presubmit-Ready: Alexis Hétu sugoi@google.com
Reviewed-by: Corentin Wallez cwallez@google.com
Reviewed-by: Chris Forbes chrisforbes@google.com
Tested-by: Alexis Hétu sugoi@google.com

Notes: Security: backported fix for 1115345.

@nornagon nornagon requested a review from a team as a code owner September 1, 2020 19:48
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 1, 2020
@nornagon nornagon added 9-x-y backport-check-skip Skip trop's backport validity checking labels Sep 1, 2020
@nornagon nornagon added 8-x-y and removed 9-x-y labels Sep 1, 2020
@nornagon nornagon merged commit 2cf35c0 into 8-x-y Sep 2, 2020
@release-clerk
Copy link

release-clerk bot commented Sep 2, 2020

Release Notes Persisted

Security: backported fix for 1115345.

@nornagon nornagon deleted the cherry-pick/8-x-y/swiftshader/c4f3b713800f branch September 2, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8-x-y backport-check-skip Skip trop's backport validity checking new-pr 🌱 PR opened in the last 24 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants