Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 0dc563cbbca5 from chromium #25239

Merged
merged 3 commits into from Sep 2, 2020

Conversation

nornagon
Copy link
Member

indexeddb: reset async tasks in ~WebIDBGetDBNamesCallbacksImpl

Since sometimes the WebIDBGetDBNamesCallbacksImpl can be destroyed when
the promise is resolved, make sure that no code that could reference it
is still around. Store the async task as an optional member so it can
be cleared during the destructor.

Followup to:
https://chromium-review.googlesource.com/c/chromium/src/+/2311620

(cherry picked from commit 4422ec665ddca3ac05ad90bac5d5ebee7cfc5536)

Bug: 1106682,1109467
Change-Id: Id6a0ff0a3703fab94e9684e41f16d5a1bac20468
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321332
Reviewed-by: Daniel Murphy dmurph@chromium.org
Commit-Queue: enne enne@chromium.org
Auto-Submit: enne enne@chromium.org
Cr-Original-Commit-Position: refs/heads/master@{#792121}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337110
Reviewed-by: enne enne@chromium.org
Cr-Commit-Position: refs/branch-heads/4147@{#1029}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}

Notes: Security: backported fix for 1106682,1109467.

@nornagon nornagon requested a review from a team as a code owner August 31, 2020 23:28
@nornagon nornagon added 8-x-y backport-check-skip Skip trop's backport validity checking labels Aug 31, 2020
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 31, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 1, 2020
@nornagon nornagon merged commit 4ad543c into 8-x-y Sep 2, 2020
@release-clerk
Copy link

release-clerk bot commented Sep 2, 2020

Release Notes Persisted

Security: backported fix for 1106682,1109467.

@nornagon nornagon deleted the cherry-pick/8-x-y/chromium/0dc563cbbca5 branch September 2, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8-x-y backport-check-skip Skip trop's backport validity checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants