Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose currencyCode on Product object in IAP module #25085

Merged
merged 1 commit into from
Aug 27, 2020
Merged

feat: expose currencyCode on Product object in IAP module #25085

merged 1 commit into from
Aug 27, 2020

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Aug 21, 2020

Backport of #25058

See that PR for details.

Notes: Added the currencyCode field that Apple's StoreKit in-app-purchasing library provides but has not been added to the Product object that inAppPurchase.getProducts returns.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 21, 2020
@trop trop bot mentioned this pull request Aug 21, 2020
Merged
6 tasks
@trop trop bot added 9-x-y backport This is a backport PR backport/requested 🗳 labels Aug 21, 2020
@codebytere codebytere requested a review from a team August 21, 2020 17:43
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 22, 2020
jkleinsc
jkleinsc previously requested changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as requesting changes until @electron/wg-releases can review for backport

@MarshallOfSound MarshallOfSound dismissed jkleinsc’s stale review August 27, 2020 18:46

Approved by Releases WG

@MarshallOfSound MarshallOfSound merged commit 7651036 into 9-x-y Aug 27, 2020
@release-clerk
Copy link

release-clerk bot commented Aug 27, 2020

Release Notes Persisted

Added the currencyCode field that Apple's StoreKit in-app-purchasing library provides but has not been added to the Product object that inAppPurchase.getProducts returns.

@MarshallOfSound MarshallOfSound deleted the trop/9-x-y-bp-feat-expose-currencycode-on-product-object-in-iap-module-1598031715343 branch August 27, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@jkleinsc jkleinsc jkleinsc left review comments

Assignees
No one assigned
Labels
9-x-y backport/requested 🗳 backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jkleinsc @MarshallOfSound