Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [a11y] Allow focus to move into an editable combobox's listbox #25004

Merged
merged 3 commits into from
Aug 18, 2020
Merged

fix: [a11y] Allow focus to move into an editable combobox's listbox #25004

merged 3 commits into from
Aug 18, 2020

Conversation

deepak1556
Copy link
Member

@deepak1556 deepak1556 commented Aug 17, 2020 •
edited

Description of Change

Backports #25003

Checklist

Release Notes

Notes: [a11y] fix an issue where voiceover doesn't read the first item selected from a ARIA combobox

@deepak1556 deepak1556 requested a review from a team as a code owner August 17, 2020 20:42
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 17, 2020
@trop trop bot mentioned this pull request Aug 17, 2020
Merged
7 tasks
@trop trop bot added 9-x-y backport This is a backport PR labels Aug 17, 2020
@deepak1556 deepak1556 added the backport-check-skip Skip trop's backport validity checking label Aug 17, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 17, 2020
codebytere
codebytere approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving pending conflict rebase

@codebytere codebytere merged commit eefcbda into 9-x-y Aug 18, 2020
@codebytere codebytere deleted the robo/fix_a11y_list_9_x branch August 18, 2020 17:33
@release-clerk
Copy link

release-clerk bot commented Aug 18, 2020

Release Notes Persisted

[a11y] fix an issue where voiceover doesn't read the first item selected from a ARIA combobox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
9-x-y backport This is a backport PR backport-check-skip Skip trop's backport validity checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@deepak1556 @codebytere