chore: cherry-pick fix from chromium issue 1113227

[danbrianwhite]

Description of Change

Currently, when the underlying network connection breaks from changing network IP address, the underlying chromium network connection does not update with the new IP address for RTC. This causes all RTC connections to fail after this scenario happens. The only way to work around this issue is to completely close the tab or restart the electron application.

The Chromium team created a fix for this in the master branch and the git hash https://chromium.googlesource.com/chromium/src/+/72ac0aae53384a914ea11e4f71dfcb81cf53830b. This PR is to cherry pick this fix on top of the version of chromium used by Electron 9-x-y and then create a patch file.

The original conversation on the bug board can be followed at https://bugs.chromium.org/p/chromium/issues/detail?id=1113227.

Backport https://chromium.googlesource.com/chromium/src/+/72ac0aae53384a914ea11e4f71dfcb81cf53830b

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• PR title follows semantic commit guidelines
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
• This is NOT A BREAKING CHANGE. Breaking changes may not be merged to master until 11-x-y is branched.

Release Notes

Notes: Resolve network issues that prevented RTC calls from being connected due to network IP address changes and ICE. (Chromium issue 1113227)

[welcome]

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

• fix: don't overwrite prevent_default if default wasn't prevented
• feat: add app.isPackaged() method
• docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

• Follow the JavaScript, C++, and Python coding style.
• Run npm run lint locally to catch formatting errors earlier.
• Document any user-facing changes you've made following the documentation styleguide.
• Include tests when adding/changing behavior.
• Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

[danbrianwhite]

Hello electron team. Please let me know if there are any steps or guidelines I missed in this PR. I'm also going to open a PR request against 10-x-y.

Currently this issue is impacting Symphony.com Electron application. We tested this patch on a local build of electron and saw it fixed the issue with RTC and network IP fix.

If there are any questions or concerns, please let me know. Any and all assistance is much appreciated.

Thanks!

[deepak1556]

LGTM based on https://bugs.chromium.org/p/chromium/issues/detail?id=1113227#c66. Thanks! feel free to create a backport for 10-x-y

there is build failure in applying the patch, can you please fix it.

[deepak1556]

Download https://630330-9384267-gh.circle-artifacts.com/0/patches/update-patches.patch and cd electron/ && git am --3way <downloaded patch>

[danbrianwhite]

@deepak1556 thanks so much for the help. I ran the merge, squashed, and pushed. 🤞

[danbrianwhite]

@deepak1556 I also created the backport for 10-x-y
#24998

[deepak1556]

Can you rebase to fix conflict, thanks!

[danbrianwhite]

@deepak1556 - rebased and pushed. Thanks!

[welcome]

Congrats on merging your first pull request! 🎉🎉🎉

[release-clerk]

Release Notes Persisted

Resolve network issues that prevented RTC calls from being connected due to network IP address changes and ICE. (Chromium issue 1113227)

[danbrianwhite]

Thank you so much all. The assistance is greatly appreciated.