Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send guid with linux crashes #24898

Merged

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Aug 7, 2020

Backport of #24881

See that PR for details.

Notes: Fixed missing guid parameter in Linux crash reports.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 7, 2020
@trop trop bot requested a review from nornagon August 7, 2020 22:31
@trop trop bot mentioned this pull request Aug 7, 2020
6 tasks
@trop trop bot added 9-x-y backport This is a backport PR labels Aug 7, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 7, 2020
@codebytere
Copy link
Member

@nornagon

../../electron/shell/browser/api/electron_api_crash_reporter.cc:108:47: error: too few arguments to function call, expected 3, have 2
  base::WriteFile(GetClientIdPath(), client_id);
  ~~~~~~~~~~~~~~~                             ^
../../base/files/file_util.h:394:17: note: 'WriteFile' declared here
BASE_EXPORT int WriteFile(const FilePath& filename, const char* data,
                ^
1 error generated.

this one's dead for real

@nornagon
Copy link
Member

@codebytere codebytere merged commit 8dc38cb into 9-x-y Aug 10, 2020
@release-clerk
Copy link

release-clerk bot commented Aug 10, 2020

Release Notes Persisted

Fixed missing guid parameter in Linux crash reports.

@codebytere codebytere deleted the trop/9-x-y-bp-fix-send-guid-with-linux-crashes-1596839469610 branch August 10, 2020 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants