Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: loading dedicated/shared worker scripts over custom protocol #24750

Merged
merged 4 commits into from
Aug 17, 2020
Merged

fix: loading dedicated/shared worker scripts over custom protocol #24750

merged 4 commits into from
Aug 17, 2020

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jul 28, 2020

Backport of #20625

See that PR for details.

Notes:

  • fix loading shared worker scripts over custom protocol
  • fix crash when loading worker scripts with nodeIntegration enabled

@trop trop bot requested a review from a team as a code owner July 28, 2020 01:49
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 28, 2020
@trop trop bot requested a review from deepak1556 July 28, 2020 01:49
@trop trop bot mentioned this pull request Jul 28, 2020
Merged
6 tasks
@trop trop bot added 9-x-y backport This is a backport PR labels Jul 28, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 28, 2020
@deepak1556 @codebytere
fix: add patch to avoid crash in worker with nodeintegration enabled
e0176da 
[worker_global_scope.cc(111)] Check failed: url_.IsValid().
@codebytere codebytere force-pushed the trop/9-x-y-bp-fix-loading-dedicated-shared-worker-scripts-over-custom-protocol-1595900935098 branch from 011483d to e0176da Compare August 6, 2020 15:27
jkleinsc
jkleinsc requested changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the new test is failing on WOA

@jkleinsc jkleinsc merged commit e2c4e34 into 9-x-y Aug 17, 2020
@release-clerk
Copy link

release-clerk bot commented Aug 17, 2020

Release Notes Persisted

  • fix loading shared worker scripts over custom protocol
  • fix crash when loading worker scripts with nodeIntegration enabled

@jkleinsc jkleinsc deleted the trop/9-x-y-bp-fix-loading-dedicated-shared-worker-scripts-over-custom-protocol-1595900935098 branch August 17, 2020 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@deepak1556 deepak1556 Awaiting requested review from deepak1556

Assignees
No one assigned
Labels
9-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jkleinsc @deepak1556 @codebytere