Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cherry-pick fix from chromium issue 1042986 #24624

Merged
merged 1 commit into from Jul 20, 2020
Merged

chore: cherry-pick fix from chromium issue 1042986 #24624

merged 1 commit into from Jul 20, 2020

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented Jul 17, 2020

[1042986] [Low] [CVE-2020-6531]: iframe in victim page can detect Scroll To Text Fragment activation
Backport https://chromium.googlesource.com/chromium/src/+/6ba752a6236a1adfff4b552bf141abd20f81fa4c

Notes: fix: iframe in victim page can detect Scroll To Text Fragment activation. (Chromium security issue 1042986)

@zcbenz zcbenz added 9-x-y backport-check-skip Skip trop's backport validity checking labels Jul 17, 2020
@zcbenz zcbenz requested a review from a team as a code owner July 17, 2020 10:29
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 17, 2020
deepak1556
deepak1556 approved these changes Jul 18, 2020
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't fix the behavior for nodeIntegration: true because of how we handle history navigations, guess thats fine.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 18, 2020
@zcbenz zcbenz force-pushed the cherry-pick/1042986/9-x-y branch from 9fc2fcc to 4fd0e5c Compare July 20, 2020 02:54
@zcbenz zcbenz merged commit 9307bf2 into 9-x-y Jul 20, 2020
@release-clerk
Copy link

release-clerk bot commented Jul 20, 2020

Release Notes Persisted

fix: iframe in victim page can detect Scroll To Text Fragment activation. (Chromium security issue 1042986)

@zcbenz zcbenz deleted the cherry-pick/1042986/9-x-y branch July 20, 2020 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees
No one assigned
Labels
9-x-y backport-check-skip Skip trop's backport validity checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zcbenz @deepak1556