Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Node.js cpu and heap profiling #24541

Merged
merged 1 commit into from Jul 14, 2020
Merged

fix: Node.js cpu and heap profiling #24541

merged 1 commit into from Jul 14, 2020

Conversation

codebytere
Copy link
Member

Backport of #24528.

See that PR for more details.

Notes: Fixed an issue where cpu and heap profiling in Node.js did not work properly with --cpu-prof, --heap-prof, and related CLI flags.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 14, 2020
@trop trop bot mentioned this pull request Jul 14, 2020
6 tasks
@trop trop bot added 9-x-y backport This is a backport PR labels Jul 14, 2020
@codebytere codebytere requested a review from a team July 14, 2020 16:06
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 14, 2020
* fix: Node.js cpu and heap profiling

* chore: emable more now-working Node.js specs
@codebytere codebytere merged commit 4e202b8 into 9-x-y Jul 14, 2020
@release-clerk
Copy link

release-clerk bot commented Jul 14, 2020

Release Notes Persisted

Fixed an issue where cpu and heap profiling in Node.js did not work properly with --cpu-prof, --heap-prof, and related CLI flags.

@codebytere codebytere deleted the node-heap-prof-9 branch July 14, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants