Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: always callback error with invalid print settings #24508

Merged
merged 2 commits into from Jul 13, 2020
Merged

fix: always callback error with invalid print settings #24508

merged 2 commits into from Jul 13, 2020

Conversation

codebytere
Copy link
Member

Backport of #24476.

See that PR for more details.

Notes: Fixed an issue where webContents.print() would sometimes hang with invalid settings.

@codebytere codebytere requested a review from a team as a code owner July 10, 2020 17:20
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 10, 2020
@trop trop bot mentioned this pull request Jul 10, 2020
Merged
6 tasks
@trop trop bot added 9-x-y backport This is a backport PR labels Jul 10, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 10, 2020
@jkleinsc jkleinsc merged commit f59d898 into 9-x-y Jul 13, 2020
@release-clerk
Copy link

release-clerk bot commented Jul 13, 2020

Release Notes Persisted

Fixed an issue where webContents.print() would sometimes hang with invalid settings.

@jkleinsc jkleinsc deleted the print-settings-cb-9 branch July 13, 2020 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
9-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @jkleinsc