Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add app render-process-gone event #24315

Merged
merged 1 commit into from Jul 3, 2020
Merged

feat: add app render-process-gone event #24315

merged 1 commit into from Jul 3, 2020

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jun 26, 2020

Backport of #23560

See that PR for details.

Notes: Added new render-process-gone event on app to replace the renderer-process-crashed event.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 26, 2020
@trop trop bot requested a review from miniak June 26, 2020 15:31
@trop trop bot mentioned this pull request Jun 26, 2020
Merged
6 tasks
@trop trop bot added 9-x-y backport This is a backport PR labels Jun 26, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 27, 2020
@codebytere
Copy link
Member

@miniak the backport itself is approved by the Release WG, but we don't want to backport the deprecation until 10, so once it's removed we can merge this.

This is also failing relevant tests

@miniak miniak force-pushed the trop/9-x-y-bp-feat-add-app-render-process-gone-event-1593185473040 branch from be6d55a to 627a4e6 Compare July 3, 2020 10:20
@miniak
Copy link
Contributor

miniak commented Jul 3, 2020

@codebytere deprecation removed. The tests were failing because this PR depends on #24309

@codebytere codebytere merged commit 4515c4d into 9-x-y Jul 3, 2020
@release-clerk
Copy link

release-clerk bot commented Jul 3, 2020

Release Notes Persisted

Added new render-process-gone event on app to replace the renderer-process-crashed event.

@codebytere codebytere deleted the trop/9-x-y-bp-feat-add-app-render-process-gone-event-1593185473040 branch July 3, 2020 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniak miniak miniak approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
9-x-y backport/approved ✅ backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @miniak