Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove dead symlink from MAS build #24238

Merged
merged 1 commit into from Jun 22, 2020

Conversation

MarshallOfSound
Copy link
Member

Backport of #24158

See that PR for details.

Notes: Fixed mac app store rejection notice for invalid symbolic link in bundle.

* build: remove dead symlink from MAS build

* chore: new out cache

* build: fixup gn check

* Update node_main.cc

* chore: fix lint
@trop trop bot added 9-x-y backport This is a backport PR labels Jun 22, 2020
@codebytere codebytere self-requested a review June 22, 2020 16:44
@codebytere codebytere changed the title build: remove dead symlink from MAS build (#24158) build: remove dead symlink from MAS build Jun 22, 2020
@MarshallOfSound MarshallOfSound merged commit 31e8b9f into 9-x-y Jun 22, 2020
@release-clerk
Copy link

release-clerk bot commented Jun 22, 2020

Release Notes Persisted

Fixed mac app store rejection notice for invalid symbolic link in bundle.

@MarshallOfSound MarshallOfSound deleted the fix-dead-symlink-on-mas-9 branch June 22, 2020 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants