Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: let Node.js perform microtask checkpoint in the main process #24178

Merged
merged 1 commit into from Jun 17, 2020

Conversation

deepak1556
Copy link
Member

@deepak1556 deepak1556 commented Jun 17, 2020

Description of Change

Backports #24131

Checklist

Release Notes

Notes: fix delayed execution of some Node.js callbacks in the main process

…4131)

* fix: let Node.js perform microtask checkpoint in the main process

* fix: don't specify v8::MicrotasksScope for explicit policy

* fix: remove checkpoint from some call-sites

We already perform checkpoint at the end of a task,
either through MicrotaskRunner or through NodeBindings.
There isn't a need to add them again when calling into JS
except when dealing with promises.

* fix: remove checkpoint from some call-sites

We already perform checkpoint at the end of a task,
either through MicrotaskRunner or through NodeBindings.
There isn't a need to add them again when calling into JS
except when dealing with promises.

* fix incorrect specs

* default constructor arguments are considered for explicit mark

* add regression spec
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 17, 2020
@trop trop bot added 9-x-y backport This is a backport PR labels Jun 17, 2020
@deepak1556 deepak1556 requested a review from a team June 17, 2020 18:19
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 17, 2020
@deepak1556 deepak1556 merged commit f11aad0 into 9-x-y Jun 17, 2020
@release-clerk
Copy link

release-clerk bot commented Jun 17, 2020

Release Notes Persisted

fix delayed execution of some Node.js callbacks in the main process

@deepak1556 deepak1556 deleted the robo/fix_checkpoint_9_x branch June 17, 2020 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants