Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: showing certificate dialog with no window #24121

Merged
merged 1 commit into from Jun 13, 2020
Merged

fix: showing certificate dialog with no window #24121

merged 1 commit into from Jun 13, 2020

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jun 13, 2020

Backport of #24091

See that PR for details.

Notes: Fixed an error when calling dialog.showCertificateTrustDialog with no BrowserWindow.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 13, 2020
@trop trop bot requested a review from codebytere June 13, 2020 05:18
@trop trop bot mentioned this pull request Jun 13, 2020
Merged
7 tasks
@trop trop bot added 9-x-y backport This is a backport PR labels Jun 13, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 13, 2020
@codebytere codebytere merged commit 496b0f8 into 9-x-y Jun 13, 2020
@release-clerk
Copy link

release-clerk bot commented Jun 13, 2020

Release Notes Persisted

Fixed an error when calling dialog.showCertificateTrustDialog with no BrowserWindow.

@codebytere codebytere deleted the trop/9-x-y-bp-fix-showing-certificate-dialog-with-no-window-1592025507519 branch June 13, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
9-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@codebytere