Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fs.readdir/readdirSync should support withFileTypes #24108

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jun 12, 2020

Backport of #24062

See that PR for details.

Notes: Fixes an issue where withFileTypes was not supported as an option to fs.readdir or fs.readdirSync under asar.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 12, 2020
@trop trop bot requested a review from codebytere June 12, 2020 15:33
@trop trop bot added 9-x-y backport This is a backport PR labels Jun 12, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 12, 2020
@codebytere codebytere merged commit 0d80baf into 9-x-y Jun 12, 2020
@release-clerk
Copy link

release-clerk bot commented Jun 12, 2020

Release Notes Persisted

Fixes an issue where withFileTypes was not supported as an option to fs.readdir or fs.readdirSync under asar.

@codebytere codebytere deleted the trop/9-x-y-bp-fix-fs-readdir-readdirsync-should-support-withfiletypes-1591976001309 branch June 12, 2020 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant