Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick c20afc96e36f57 from chromium #24059

Merged
merged 2 commits into from Jun 17, 2020
Merged

Conversation

deepak1556
Copy link
Member

@deepak1556 deepak1556 commented Jun 11, 2020

Description of Change

Backports https://chromium-review.googlesource.com/c/chromium/src/+/2233234

Refs #24055

Checklist

Release Notes

Notes: fix issue with some IMEs on windows (for ex: Zhuyin) don't terminate after pressing shift

@deepak1556 deepak1556 requested a review from a team as a code owner June 11, 2020 02:36
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 11, 2020
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already in the next chromium roll for master (#23908) and 10-x-y (#23987) so it doesn't really need to be cherry-picked to those branches.

@deepak1556 deepak1556 requested a review from a team as a code owner June 11, 2020 20:02
@deepak1556 deepak1556 changed the base branch from master to 9-x-y June 11, 2020 20:03
@deepak1556 deepak1556 added backport-check-skip Skip trop's backport validity checking and removed target/9-x-y wip ⚒ labels Jun 11, 2020
@deepak1556 deepak1556 closed this Jun 11, 2020
@deepak1556 deepak1556 reopened this Jun 11, 2020
@deepak1556
Copy link
Member Author

@jkleinsc updated, thanks!

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 12, 2020
@deepak1556 deepak1556 dismissed jkleinsc’s stale review June 17, 2020 17:18

unblocking merge :)

@deepak1556
Copy link
Member Author

Failing test is unrelated, merging.

@deepak1556 deepak1556 merged commit b0cbf49 into 9-x-y Jun 17, 2020
@release-clerk
Copy link

release-clerk bot commented Jun 17, 2020

Release Notes Persisted

fix issue with some IMEs on windows (for ex: Zhuyin) don't terminate after pressing shift

@deepak1556 deepak1556 deleted the robo/zhuyin_ime branch June 17, 2020 19:15
@trop
Copy link
Contributor

trop bot commented Jun 17, 2020

I was unable to backport this PR to "8-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/8-x-y label Jun 17, 2020
@trop
Copy link
Contributor

trop bot commented Jun 17, 2020

@deepak1556 has manually backported this PR to "8-x-y", please check out #24181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9-x-y backport-check-skip Skip trop's backport validity checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants