Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backport libuv patch for failure to load advapi32 #24039

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jun 9, 2020

Backport of #24030

See that PR for details.

Notes: Fixed: On some Windows machines, especially Windows Insider builds, Electron would crash silently during startup.

@trop trop bot requested a review from a team as a code owner June 9, 2020 21:26
@trop trop bot requested a review from felixrieseberg June 9, 2020 21:27
@trop trop bot added 9-x-y backport This is a backport PR labels Jun 9, 2020
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing tests are unrelated

adill pushed a commit to discord/electron that referenced this pull request Jun 11, 2020
@zcbenz zcbenz merged commit 974be18 into 9-x-y Jun 11, 2020
@release-clerk
Copy link

release-clerk bot commented Jun 11, 2020

Release Notes Persisted

Fixed: On some Windows machines, especially Windows Insider builds, Electron would crash silently during startup.

@zcbenz zcbenz deleted the trop/9-x-y-bp-fix-backport-libuv-patch-for-failure-to-load-advapi32-1591738008752 branch June 11, 2020 03:55
ItsSim added a commit to ItsSim/fsolauncher that referenced this pull request Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants