Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default to NTLM v2 in the network service for POSIX platforms #23934

Merged
merged 4 commits into from Jun 7, 2020
Merged

fix: default to NTLM v2 in the network service for POSIX platforms #23934

merged 4 commits into from Jun 7, 2020

Conversation

deepak1556
Copy link
Member

@deepak1556 deepak1556 commented Jun 3, 2020 •
edited

Description of Change

Backports #23846
Backports #23952
Backports #23864

Checklist

Release Notes

Notes: enable NTLM v2 for POSIX platforms and added --disable-ntlm-v2 switch to disable it.

@deepak1556 deepak1556 requested a review from a team as a code owner June 3, 2020 05:45
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 3, 2020
@trop trop bot mentioned this pull request Jun 3, 2020
Merged
6 tasks
@trop trop bot added 9-x-y backport This is a backport PR labels Jun 3, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 3, 2020
@deepak1556 deepak1556 removed the wip ⚒ label Jun 3, 2020
This was referenced Jun 3, 2020
Merged
Merged
@alexeykuzmin
Copy link
Contributor

enable NTLM v2 for POSIX platforms and added --disable-ntlm-v2 switch to disable it.

Can it be opt-in instead of opt-out?

@deepak1556
Copy link
Member Author

@alexeykuzmin #23846 (comment) explains why this is an opt-out.

@deepak1556 deepak1556 merged commit fc9fb0b into 9-x-y Jun 7, 2020
@release-clerk
Copy link

release-clerk bot commented Jun 7, 2020

Release Notes Persisted

enable NTLM v2 for POSIX platforms and added --disable-ntlm-v2 switch to disable it.

@deepak1556 deepak1556 deleted the robo/ntlm_v2_9_x branch June 7, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

@codebytere codebytere codebytere approved these changes

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
9-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@deepak1556 @alexeykuzmin @codebytere @MarshallOfSound