style: use build/include_directory for NOLINT #23266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
build/include linter was splitted to build/include_directory at depot_tools upstream. https://crrev.com/c/2159690 https://crbug.com/1073191
|
Congrats on merging your first pull request! 🎉🎉🎉 |
|
No Release Notes |
|
/trop run backport-to 9-x-y |
|
The backport process for this PR has been manually initiated - |
|
I have automatically backported this PR to "9-x-y", please check out #23300 |
|
/trop run backport-to 8-x-y |
|
The backport process for this PR has been manually initiated - |
|
I was unable to backport this PR to "8-x-y" cleanly; |
MarshallOfSound
pushed a commit
that referenced
this pull request
Apr 27, 2020
build/include linter was splitted to build/include_directory at depot_tools upstream. https://crrev.com/c/2159690 https://crbug.com/1073191
|
@MarshallOfSound has manually backported this PR to "8-x-y", please check out #23303 |
MarshallOfSound
added a commit
that referenced
this pull request
Apr 27, 2020
build/include linter was splitted to build/include_directory at depot_tools upstream. https://crrev.com/c/2159690 https://crbug.com/1073191 Co-authored-by: Sorah Fukumori <sora134@gmail.com>
trop bot
pushed a commit
that referenced
this pull request
Apr 27, 2020
build/include linter was splitted to build/include_directory at depot_tools upstream. https://crrev.com/c/2159690 https://crbug.com/1073191
MarshallOfSound
pushed a commit
that referenced
this pull request
Apr 27, 2020
build/include linter was splitted to build/include_directory at depot_tools upstream. https://crrev.com/c/2159690 https://crbug.com/1073191 Co-authored-by: Sorah Fukumori <sora134@gmail.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
build/include linter was splitted to build/include_directory at depot_tools upstream.
Fixing PR
lintcheck failure. (seen here: https://github.com/electron/electron/runs/614050973 #23247)https://crrev.com/c/2159690
https://crbug.com/1073191
Checklist
Release Notes
Notes: none