Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: block custom window.open when nativeWindowOpen is true (#23188) #23224

Merged
merged 3 commits into from Apr 27, 2020

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Apr 22, 2020

Backport of #23188.

Notes: Fixed an issue where windows without nativeWindowOpen: true could invoke the non-native-open path.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 22, 2020
@trop trop bot added 7-2-x backport This is a backport PR labels Apr 22, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 22, 2020
@zcbenz zcbenz merged commit 7dfcb5e into 7-2-x Apr 27, 2020
@release-clerk
Copy link

release-clerk bot commented Apr 27, 2020

Release Notes Persisted

Fixed an issue where windows without nativeWindowOpen: true could invoke the non-native-open path.

@zcbenz zcbenz deleted the backport/7-2-x/block-custom-open branch April 27, 2020 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7-2-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants