New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: block custom window.open when nativeWindowOpen is true #23188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
approved these changes
Apr 21, 2020
nornagon
force-pushed
the
block-custom-open
branch
from
April 21, 2020 20:01
da2e631
to
0c43361
Compare
deepak1556
approved these changes
Apr 21, 2020
Release Notes Persisted
|
I was unable to backport this PR to "7-2-x" cleanly; |
I was unable to backport this PR to "8-x-y" cleanly; |
I have automatically backported this PR to "9-x-y", please check out #23222 |
nornagon
added a commit
that referenced
this pull request
Apr 22, 2020
MarshallOfSound
pushed a commit
that referenced
this pull request
Apr 23, 2020
zcbenz
pushed a commit
that referenced
this pull request
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This prevents windows that have
nativeWindowOpen: true
(orsandbox: true
which implies it) from being able to use theELECTRON_GUEST_WINDOW_MANAGER_WINDOW_OPEN
ipc event, which handles non-native window.open calls.Checklist
npm test
passesRelease Notes
Notes: none