fix: don't assign NSAlert to window which is not visible #23089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
Without this change it's possible to create message box which can't be dismissed on mac.
4 tasks
jkleinsc
approved these changes
Apr 14, 2020
|
Merging as CI failures are unrelated to PR changes. |
|
Release Notes Persisted
|
jkleinsc
deleted the
trop/7-2-x-bp-fix-don-t-assign-nsalert-to-window-which-is-not-visible-1586766420318
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #22672
See that PR for details.
Notes: Fixed an issue with possible creation of a messageBox which cannot be dismissed on macOS.