Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cherry-pick 2aac556145af from v8 #23059

Merged
merged 3 commits into from Apr 13, 2020
Merged

fix: cherry-pick 2aac556145af from v8 #23059

merged 3 commits into from Apr 13, 2020

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Apr 9, 2020 •
edited

Make CreateDynamicFunction throw if disallowed

... instead of returning undefined.

Bug: chromium:1065094
Change-Id: I0b0397a8affd44b58e7f4777f32ba22bbd001ab1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2124837
Reviewed-by: Toon Verwaest verwaest@chromium.org
Commit-Queue: Georg Neis neis@chromium.org
Cr-Commit-Position: refs/heads/master@{#66902}

Notes: Security: backported a fix for crbug.com/1065094.

@nornagon nornagon requested a review from a team as a code owner April 9, 2020 17:27
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 9, 2020
@nornagon nornagon added 7-2-x backport-check-skip Skip trop's backport validity checking labels Apr 9, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 10, 2020
jkleinsc
jkleinsc approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

@nornagon nornagon merged commit 4dc2c28 into 7-2-x Apr 13, 2020
@release-clerk
Copy link

release-clerk bot commented Apr 13, 2020

Release Notes Persisted

Security: backported a fix for crbug.com/1065094.

@nornagon nornagon deleted the cherry-pick/7-2-x/v8/2aac556145af branch April 13, 2020 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
7-2-x backport-check-skip Skip trop's backport validity checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nornagon @jkleinsc