fix: backport d82a02c837d3 from WebRTC. #23037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
approved these changes
Apr 8, 2020
ACM: Corrected temporary buffer size This CL corrects the temporary buffers size in the pre-processing of the capture audio before encoding. As part of this it removes the ACM-specific hardcoding of the size and instead ensures that the size of the temporary buffer matches that of the AudioFrame.
ppontes
force-pushed
the
origin/ppontes/backport-webrtc-d82a02c837d3-to-7-2-x
branch
from
70a5cd3
to
a69a970
Compare
|
Merging as CI failure is known flake unrelated to this PR. |
jkleinsc
approved these changes
Apr 13, 2020
|
Release Notes Persisted
|
jkleinsc
deleted the
origin/ppontes/backport-webrtc-d82a02c837d3-to-7-2-x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
ACM: Corrected temporary buffer size
This CL corrects the temporary buffers size in the
pre-processing of the capture audio before encoding.
As part of this it removes the ACM-specific hardcoding
of the size and instead ensures that the size of the
temporary buffer matches that of the AudioFrame.
Bug: webrtc:11242 / chromium: 1060647
Change-Id: I56dd6cadfd4e140e8e159966c33d1027383ea9fa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170340
Commit-Queue: Per Åhgren peah@webrtc.org
Reviewed-by: Henrik Lundin henrik.lundin@webrtc.org
Reviewed-by: Henrik Andreassson henrika@webrtc.org
Cr-Commit-Position: refs/heads/master@{#30775}
Release Notes
Notes: Security: backported fix for a potential buffer overrun in WebRTC audio encoding.