Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nullptr check when closing windows #23024

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Apr 8, 2020

Backport of #22948

See that PR for details.

Notes: Fixed an occasional crash when closing all BrowserWindows.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 8, 2020
@trop trop bot requested a review from codebytere April 8, 2020 03:42
@trop trop bot mentioned this pull request Apr 8, 2020
4 tasks
@trop trop bot added 7-2-x backport This is a backport PR labels Apr 8, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 8, 2020
@codebytere codebytere merged commit 4c5197f into 7-2-x Apr 8, 2020
@release-clerk
Copy link

release-clerk bot commented Apr 8, 2020

Release Notes Persisted

Fixed an occasional crash when closing all BrowserWindows.

@codebytere codebytere deleted the trop/7-2-x-bp-fix-nullptr-check-when-closing-windows-1586317303250 branch April 8, 2020 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7-2-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant