chore: cherry-pick 728c6deeffe1 from chromium #22981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppontes
approved these changes
Apr 7, 2020
deepak1556
approved these changes
Apr 9, 2020
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speculative fix for crashes in ~FileChooserImpl()
FileChooserImpl can outlive ListenerProxy. We should clear
FileChooserImpl::proxy_ on ~ListenerProxy().
This CL has no tests. We don't know how to reproduce crashes.
Bug: 1054260
Change-Id: I2be7a8957f2f725c51081961357ef09f6dabb823
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067819
Commit-Queue: Kent Tamura tkent@chromium.org
Reviewed-by: Avi Drissman avi@chromium.org
Reviewed-by: Matthew Denton mpdenton@chromium.org
Cr-Commit-Position: refs/heads/master@{#744142}
Notes: Security: Backported fix for use after free in file chooser.